Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: always run system tests [backport 2.13] #10919

Merged
merged 3 commits into from
Oct 11, 2024
Merged

Conversation

gnufede
Copy link
Member

@gnufede gnufede commented Oct 3, 2024

CI: Removes conditions to check wether should run or "dry run" system tests, and just runs them

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance
    policy

(cherry picked from commit 7f6f3db)

CI: Removes conditions to check wether should run or "dry run" system
tests, and just runs them

- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit 7f6f3db)
@gnufede gnufede requested review from a team as code owners October 3, 2024 09:39
@gnufede gnufede changed the title ci: always run system tests (#10878) ci: always run system tests [backport 2.13] Oct 3, 2024
@gnufede gnufede added changelog/no-changelog A changelog entry is not required for this PR. CI labels Oct 3, 2024
Copy link
Contributor

github-actions bot commented Oct 3, 2024

CODEOWNERS have been resolved as:

.github/workflows/system-tests.yml                                      @DataDog/python-guild @DataDog/apm-core-python

@pr-commenter
Copy link

pr-commenter bot commented Oct 3, 2024

Benchmarks

Benchmark execution time: 2024-10-10 12:01:36

Comparing candidate commit 92c52f7 in PR branch backport-10878-to-2.13 with baseline commit a54549e in branch 2.13.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 353 metrics, 47 unstable metrics.

@gnufede gnufede enabled auto-merge (squash) October 8, 2024 17:00
@gnufede gnufede merged commit 27b3ccb into 2.13 Oct 11, 2024
528 checks passed
@gnufede gnufede deleted the backport-10878-to-2.13 branch October 11, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR. CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants