Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(profiling): explicitly link with thread library [backport-2.12] #11004

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

taegyunkim
Copy link
Contributor

@taegyunkim taegyunkim commented Oct 11, 2024

Manual backport of #10994 to 2.12

python:3.11-bookworm image for aarch64 has pthread_atfork in static libpthread.a not in libpthread.so so need to explicitly link for those cases. Otherwise, we get undefined symbol pthread_atfork.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Manual backport of #10994 to 2.12

python:3.11-bookworm image for aarch64 has `pthread_atfork` in static
libpthread.a not in libpthread.so so need to explicitly link for those
cases. Otherwise, we get undefined symbol `pthread_atfork`.
@taegyunkim taegyunkim requested review from a team as code owners October 11, 2024 09:53
@taegyunkim taegyunkim added the Profiling Continous Profling label Oct 11, 2024
@taegyunkim taegyunkim enabled auto-merge (squash) October 11, 2024 09:54
@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: backport-10994-to-2.12
Commit report: c534f0f
Test service: dd-trace-py

✅ 0 Failed, 3764 Passed, 46 Skipped, 1h 28m 16.13s Total duration (10m 20.03s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Oct 11, 2024

Benchmarks

Benchmark execution time: 2024-10-11 10:28:57

Comparing candidate commit c534f0f in PR branch backport-10994-to-2.12 with baseline commit f4be357 in branch 2.12.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 353 metrics, 47 unstable metrics.

@taegyunkim taegyunkim merged commit 262b778 into 2.12 Oct 11, 2024
258 of 260 checks passed
@taegyunkim taegyunkim deleted the backport-10994-to-2.12 branch October 11, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Profiling Continous Profling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants