Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): bump riot version for 3.7 compatibility issues [backport 2.12] #11090

Open
wants to merge 1 commit into
base: 2.12
Choose a base branch
from

Commits on Oct 18, 2024

  1. chore(ci): bump riot version for 3.7 compatibility issues [backport 2…

    ….12]
    
    Manual backport of #11085 to 2.12
    
    With the new release of virtualenv==20.27.0, we were seeing new failures
    with build_base_venv[3.7] (GitLab) and build_base_venv (CircleCI) jobs
    when running:
    ```
    riot -P -v generate --python=$PYTHON_VERSION
    ...
      File "/go/src/github.com/DataDog/apm-reliability/dd-trace-py/.riot/venv_py3717/lib/python3.7/site-packages/pip/_vendor/typing_extensions.py", line 1039
        def TypedDict(typename, fields=_marker, /, *, total=True, closed=False, **kwargs):
                                                ^
    SyntaxError: invalid syntax
    ERROR:riot.riot:Dev install failed, aborting!
    ```
    We need to pin to virtualenv==20.26.6 to continue supporting python3.7
    
    The upload-artifact and download-artifact bumps were required to unblock
    the riot CI. It had been a while since the last update to riot, and
    since then, v2 has been deprecated and v3 will be deprecated next month
    (Nov 2024), so we are bumping to v4 via tag.
    
    The above changes were implemented in riot
    (DataDog/riot#232), and this PR just bumps the
    riot version in dd-trace-py from 0.19.1 to 0.20.0
    taegyunkim committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    1cf8ced View commit details
    Browse the repository at this point in the history