Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test the metadata for counter metrics again #16630

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

FlorentClarret
Copy link
Member

@FlorentClarret FlorentClarret commented Jan 16, 2024

What does this PR do?

Test the metadata for counter metrics again

Motivation

This TODO is almost 4 years old and it is now fixed

Additional Notes

datadoghq.atlassian.net/browse/AI-3731

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

@FlorentClarret
Copy link
Member Author

FlorentClarret commented Jan 16, 2024

Current dependencies on/for this PR:

This comment was autogenerated by Freephite.

Copy link

github-actions bot commented Jan 16, 2024

Test Results

12 files  12 suites   59s ⏱️
 2 tests  2 ✅  0 💤 0 ❌
24 runs  12 ✅ 12 💤 0 ❌

Results for commit d00f631.

♻️ This comment has been updated with latest results.

Base automatically changed from florentclarret/tomcat/embedded to master January 16, 2024 16:58
@FlorentClarret FlorentClarret force-pushed the florentclarret/tomcat/counter_metrics branch from cf3de47 to d00f631 Compare January 16, 2024 17:00
@FlorentClarret FlorentClarret marked this pull request as ready for review January 16, 2024 17:00
@FlorentClarret FlorentClarret requested a review from a team as a code owner January 16, 2024 17:00
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7ef1831) 90.51% compared to head (d00f631) 90.59%.
Report is 8 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
confluent_platform ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?
tomcat 62.79% <ø> (?)
weblogic ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@FlorentClarret FlorentClarret merged commit 29669c4 into master Jan 17, 2024
36 checks passed
@FlorentClarret FlorentClarret deleted the florentclarret/tomcat/counter_metrics branch January 17, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants