Use the name if provided to identify the instance in toString() #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a JMX check is running on an `address:port` and no other identifiers is provided, the `address:port` is used as an identifier. However, it could not be unique because we want to be able to run multiple JMX instances on the same JVM. This PR modify the `Instance.toString()` method to use the name if one has been provided in the instance configuration.
arbll
approved these changes
Nov 29, 2019
This was referenced Nov 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a JMX check is running on an
address:portand no other identifiers is provided, theaddress:portis used as an identifier.However, it could not be unique because we want to be able to run multiple JMX instances on the same JVM.
This PR modify the
Instance.toString()method to use the name if one has been provided in the instance configuration, letting somebody run multiple instances of jmxfetch listening to the same JVM if a name is provided on the instances.Would provide a clean workaround for #253