[log4j] migrate to log4j2 #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivielpeau
approved these changes
Jan 10, 2020
.travis.yml
Outdated
|
|
||
| - jdk: openjdk7 | ||
| env: | ||
| - DESC="OpenJDK7 testing" | ||
| - CMD="mvn test -B -Dhttps.protocols=TLSv1.2 -Dcheckstyle.skip=true -Dlog4j.configuration=log4j.travis.properties" | ||
| - CMD="mvn test -B -Dhttps.protocols=TLSv1.2 -Dcheckstyle.skip=true -Dlog4j.configuration=log4j2.travis.properties" |
There was a problem hiding this comment.
looks like this is not picked up correctly, the property seems to be called log4j.configurationFile now, see https://logging.apache.org/log4j/2.x/manual/configuration.html
truthbk
added a commit
that referenced
this pull request
Jun 24, 2020
* [log4j] migrate to log4j2 * [travis] fix log4j config file directive * [log4j2] support STDERR and STDOUT as ways to refer to log location too
truthbk
added a commit
that referenced
this pull request
Jun 24, 2020
* [log4j] migrate to log4j2 * [travis] fix log4j config file directive * [log4j2] support STDERR and STDOUT as ways to refer to log location too
truthbk
added a commit
that referenced
this pull request
Jul 7, 2020
* Merge pull request #223 from tylerbenson/tyler/slf4j-logging Log via slf4j instead of directly to log4j * [log4j] migrate to log4j2 (#258) * [log4j] migrate to log4j2 * [travis] fix log4j config file directive * [log4j2] support STDERR and STDOUT as ways to refer to log location too Co-authored-by: Tyler Benson <[email protected]>
truthbk
added a commit
that referenced
this pull request
Aug 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's migrate to log4j2, it's probably about time.
currently testing and fixing some minor stuff