Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates deps and and adds more JDK versions in CI #437

Merged
merged 7 commits into from
May 10, 2023
Merged

Updates deps and and adds more JDK versions in CI #437

merged 7 commits into from
May 10, 2023

Conversation

scottopell
Copy link
Contributor

@scottopell scottopell commented May 10, 2023 •
edited
Loading

Now that #427 has been merged, this PR should take care of the remaining issues preventing tests from running on more modern JDK versions.

Main changes here:

  • Updates lombok and mockito to resolve tools.jar dependency errors
  • Updates how local management agent is started in java 8+
  • Adds more JDK versions to test matrix using new circleci convenience images.

@scottopell scottopell changed the title Updates lombok and mockito to ideally get tests passing on modern JDKs Updates deps and and adds more JDK versions in CI May 10, 2023
@scottopell scottopell marked this pull request as ready for review May 10, 2023 17:13
@scottopell scottopell merged commit 65aed6f into master May 10, 2023
@carlosroman carlosroman deleted the sopell/modern-jdk branch May 11, 2023 07:55
This was referenced May 30, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gh123man gh123man gh123man approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scottopell @gh123man