Display internal metrics on status #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 21427bf.
rayz
changed the title
urseberry
previously approved these changes
Sep 6, 2023
carlosroman
reviewed
Sep 6, 2023
carlosroman
approved these changes
Sep 7, 2023
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We want to be able to view JMXFetch instance data via the
datadog-agent statuscommand.Implementation:
Add the metrics onto the instanceStats map
New Output:
How it looks when theres a single JMXFetch instance
How it looks when there are multiple
There does not seem to be an order in the output of the JMXFetch instance keys in status. See jmxfetch.tmpl
I have changes incoming to set the specific order to make the output clear. The screenshots are following this order
Test/Reproduction for above screenshots:
datadog-agent/dev/dist/jmx/jmxfetch.jar