Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IBM J9 gc metrics #534

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Add IBM J9 gc metrics #534

merged 1 commit into from
Aug 7, 2024

Conversation

amarziali
Copy link
Contributor

@amarziali amarziali commented Aug 6, 2024

IBM J9 garbage collector MXBeans differ from the openjdk ones since they have different policy and exposes mbeans with different names.

This PR adds new gc metrics for major and minor collections for all the supported gc policies (https://www.ibm.com/docs/en/sdk-java-technology/8?topic=options-xgcpolicy)

Jira Ticket: FRAGENT-1747

@amarziali amarziali requested a review from a team as a code owner August 6, 2024 08:28
@amarziali amarziali requested a review from mcculls August 6, 2024 08:28
Copy link
Contributor

@mcculls mcculls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlosroman
Copy link
Contributor

@amarziali Would this here be the Docker image to test these changes with?

@amarziali
Copy link
Contributor Author

@amarziali Would this here be the Docker image to test these changes with?

Yes @carlosroman ! I can also suggest to act on -Xgcpolicy to change the gc policy in order to gather the metrics from different mbeans. Other than gencon being the default, I suggest having a try setting -Xgcpolicy:balanced. The other policies are a bit more unconventional and uses only major collections

@carlosroman
Copy link
Contributor

@amarziali Thanks for the input. Can I check that this is what you expect to see as the metrics here?

@amarziali
Copy link
Contributor Author

@amarziali Thanks for the input. Can I check that this is what you expect to see as the metrics here?

@carlosroman it looks ok. Sorry not having added those tests on this PR at this point. :) I imagine we can close this PR when the other will be merged

@carlosroman
Copy link
Contributor

@amarziali Don't worry. I'll just add the tests as a separate PR to main. Have approved this and will merge it now.

@carlosroman carlosroman merged commit 9d28e88 into master Aug 7, 2024
9 checks passed
@carlosroman carlosroman deleted the andrea.marziali/j9-gc branch August 7, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants