Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lint task #107

Merged
merged 2 commits into from
Sep 12, 2023
Merged

Remove lint task #107

merged 2 commits into from
Sep 12, 2023

Conversation

Kesin11
Copy link
Collaborator

@Kesin11 Kesin11 commented Sep 11, 2023

Description

Lint job has been broken since #103.
These errors seem to be caused by something that has changed with the latest TypeScript.

Run npm run lint

> [email protected] lint
> ts-standard src/**/*

ts-standard: Standard for TypeScript! (https:/standard/ts-standard)
  /home/runner/work/setup-job-workspace-action/setup-job-workspace-action/src/github_env.ts:0:0: Parsing error: DeprecationError: 'originalKeywordKind' has been deprecated since v[5](https:/DeNA/setup-job-workspace-action/actions/runs/6132588829/job/16643613458#step:5:6).0.0 and can no longer be used. Use 'identifierToKeywordKind(identifier)' instead. (null)
  /home/runner/work/setup-job-workspace-action/setup-job-workspace-action/src/main.ts:0:0: Parsing error: DeprecationError: 'originalKeywordKind' has been deprecated since v5.0.0 and can no longer be used. Use 'identifierToKeywordKind(identifier)' instead. (null)
  /home/runner/work/setup-job-workspace-action/setup-job-workspace-action/src/post.ts:0:0: Parsing error: DeprecationError: 'originalKeywordKind' has been deprecated since v5.0.0 and can no longer be used. Use 'identifierToKeywordKind(identifier)' instead. (null)
  /home/runner/work/setup-job-workspace-action/setup-job-workspace-action/src/workspace.ts:0:0: Parsing error: DeprecationError: 'originalKeywordKind' has been deprecated since v5.0.0 and can no longer be used. Use 'identifierToKeywordKind(identifier)' instead. (null)

Unfortunately, standard/ts-standard is not in active development, so I have removed Lint task because this repository is not large to need lint.

Related issue:

Contributor License Agreements

The development of standard/ts-standard seems to be no longer active.
@Kesin11 Kesin11 added the ci Fix only CI code label Sep 11, 2023
Copy link
Collaborator

@srz-zumix srz-zumix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Kesin11 Kesin11 merged commit 0926017 into DeNA:main Sep 12, 2023
14 checks passed
@Kesin11 Kesin11 deleted the remove_ts_standard branch September 12, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Fix only CI code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants