Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve gapi HttpRequestPromise thanks to TypeScript 2.3 #16194

Merged

Conversation

tkrotoff
Copy link
Contributor

@tkrotoff tkrotoff commented Apr 28, 2017

TypeScript 2.3 has been released, let's improve gapi HttpRequestPromise.

See the related TypeScript promise issue that has been fixed with version 2.3

Not to be merged yet: Travis CI will fail until TypeScript 2.3 is supported

@dt-bot
Copy link
Member

dt-bot commented Apr 28, 2017

types/gapi/index.d.ts

to author (@sgtfrankieboy). Could you review this PR?
👍 or 👎?

Checklist

  • pass the Travis CI test?

@mhegazy
Copy link
Contributor

mhegazy commented Jun 1, 2017

Thanks for your contribution. This PR has failing CI tests and can not be merged in at the time being. For housekeeping purposes we are closing stale PRs. If you'd still like to merge this code in, please open a new PR that has been merged and rebased with the master branch.

@mhegazy mhegazy closed this Jun 1, 2017
@tkrotoff
Copy link
Contributor Author

tkrotoff commented Jun 1, 2017

@mhegazy This PR is valid and has been reviewed. It's just waiting for DefinitelyTyped to support TypeScript 2.3 => that's why Travis CI fails
Please re-open

@rbuckton
Copy link
Collaborator

rbuckton commented Jun 1, 2017

@tkrotoff I re-ran the Travis CI build and it is still failing. This is because the following DT packages depend on gapi and have not also been updated to include // TypeScript Version: 2.3:

  • gapi.analytics
  • gapi.auth2
  • gapi.calendar
  • gapi.pagespeedonline
  • gapi.people
  • gapi.plus
  • gapi.translate
  • gapi.urlshortener
  • gapi.youtube
  • gapi.youtubeanalytics

You can see the build errors here: https://travis-ci.org/DefinitelyTyped/DefinitelyTyped/builds/226723664

Please correct the above errors and resubmit a new PR. Thanks!

@tkrotoff
Copy link
Contributor Author

tkrotoff commented Jun 1, 2017

@rbuckton If you reopen this PR, I would be able to fix the other definitions...

@rbuckton rbuckton reopened this Jun 1, 2017
@tkrotoff
Copy link
Contributor Author

tkrotoff commented Jun 1, 2017

@rbuckton thx :)

@tkrotoff
Copy link
Contributor Author

tkrotoff commented Jun 2, 2017

@rbuckton would be nice to have an announcement system (like https:/aspnet/Announcements ?) so contributors are aware when a new version of TypeScript is supported on DefinitelyTyped

@mhegazy mhegazy merged commit 78869f8 into DefinitelyTyped:master Jun 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants