Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

creating a law with an Official ID used by a deleted law fails #472

Closed
gvilarino opened this issue Dec 1, 2014 · 2 comments
Closed

creating a law with an Official ID used by a deleted law fails #472

gvilarino opened this issue Dec 1, 2014 · 2 comments
Assignees
Labels

Comments

@gvilarino
Copy link
Member

Pre-reqs:

  • Clean db
  • Be admin
  • Have at least one tag

Repro:

  1. Log in
  2. Navigate to /admin/laws/create
  3. Create a law with something as Official ID (e.g.: TestID)
  4. Delete law created in 3.
  5. Try to create a law with same Official ID as in 3.
  6. FFFFFFUUUUUU
@gvilarino
Copy link
Member Author

It seems it has to do with the lawId property. Even if it's not a required property, it is part of a unique composite index and that may be breaking it.

@jaakkokorhonen
Copy link

If a law with empty id was created, new ones cannot be created, and there is no error message.

Even fixing the state where the same id was deleted, does not solve the issue of not having any user interaction. Some messages should be posted for the user.

This is especially problematic because user is prompted that their document was saved and when user navigates to law list for publishing the law, user loses their data.

Moreover, if the law cannot be created without something in the field, the field should be handled as mandatory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants