Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme): Added ProfCyberNaught to examples #198

Merged
merged 3 commits into from Mar 23, 2023
Merged

docs(readme): Added ProfCyberNaught to examples #198

merged 3 commits into from Mar 23, 2023

Conversation

ghost
Copy link

@ghost ghost commented Mar 18, 2023

Adding ProfCyberNaught to the example usage section as I am actively using this feature on my profile page on GitHub.

Summary

I have been using this feature on my profile for a while now (at the very top) and notice, you were able to submit a pull request containing your own profile image and link to profile on GitHub. I think this is a great idea to demonstrate the usage scenario on active and engaged profiles.

I have added my own profile image, along with a link to my GitHub profile page, and the link title text: ProfCyberNaught on GitHub.

Type of change

  • Updated documentation (updated the readme, templates, or other repo files)

How Has This Been Tested?

  • Ran checks in browser and checked for errors in spelling and URL image and profile links work

Adding ProfCyberNaught to the example usage section as I am actively using this feature on my profile page on GitHub.
@DenverCoder1
Copy link
Owner

Looks great.

For consistency, it would be better to match the existing format and not include title text.

Adding title text to all profiles at the same time (in a separate PR) would be preferable.

@ghost
Copy link
Author

ghost commented Mar 22, 2023

Thanks for the feedback. If you want this additional change done to the readme regarding the Title Text changes for all current example usage profile links, can I also suggest you update the Issue #21 from:

Add a line at the bottom of the list with your name and a link to your profile

to

Add a line at the bottom of the list with your name, a link to your profile, including the title text

Clearly, only you can change the current Issue text on #21 but if you are good with the idea of correctly adding the SEO title tag to links as standard, I can create an issue for this, and get this processed for you. Just let me know,

Copy link
Author

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency, it has been suggested the title tag be removed for this commit, and a new PR be created for the change to be added to all existing profile links. A suggestion has been made to also make changes to #21 regarding the wording to request the Title Link attribute to be added along with profile name and URLs.

Copy link
Author

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to link added has been completed to remove the title attribute.

@DenverCoder1
Copy link
Owner

Great, thanks 👍

@DenverCoder1 DenverCoder1 changed the title Update README.md docs(readme): Added ProfCyberNaught to examples Mar 23, 2023
@DenverCoder1 DenverCoder1 merged commit b6ea3fa into DenverCoder1:main Mar 23, 2023
@ghost ghost deleted the patch-1 branch March 23, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant