-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for running PR checks without extra steps #21
Comments
Good idea, is this issue solved by #22? |
Yeah, that would work. In my preferred approach you would generate an app token like this:
And then pass it to the action via token instead. I guess since peter-evans/create-pull-request decided to leave that part outside it makes sense to do the same. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Would it make sense to add some configuration to allow running the PR checks without extra manual steps, e.g. with one of the solutions suggested here:
https:/peter-evans/create-pull-request/blob/main/docs/concepts-guidelines.md#workarounds-to-trigger-further-workflow-runs
Personally I went for the GitHub App generated token, which worked very well.
Basically what is outlined here:
https:/peter-evans/create-pull-request/blob/main/docs/concepts-guidelines.md#authenticating-with-github-app-generated-tokens
So perhaps we could let users configure
app_id
andprivate_key
and if they do, the necessary steps would be added.The text was updated successfully, but these errors were encountered: