-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include upstream git log in PR description, possibly even filtered? #65
Comments
A quick and dirty way of doing this could be to interpret the commit diff to leverage GitHub's compare commits feature, e.g. compare.js, example PR: tlvince/nixos-config#33. Rather than RegEx, a better way would be to hook into |
detsys-pr-bot
pushed a commit
to detsys-pr-bot/update-flake-lock
that referenced
this issue
Oct 10, 2024
…m DeterminateSystems/dependabot/npm_and_yarn/npm_and_yarn-cc3f4627d0` (`18dff575ee06557065bdbc22c099c05606a4285c`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This action looks like it’s the natural replacement for https:/knl/niv-updater-action when moving from niv to flakes.
One feature that I like a lot about niv-updater-actions is that it includes the relevant bits from the upstream git changelog in the PR description (and, somewhat related, it keeps updating the same PR until it can get merged, so if merging takes longer it will not create many PRs).
(It munges the changelog so that commit and PR references point to the right repo, and that they don’t spam upstream PRs with “this PR has been mentioned”.)
Would this be a useful feature for
update-flake-lock
as well?If so, a possible (optional) extension would be to only lists those upstream commits that actually changed the derivation of the current flake’s outputs – useful when upstream has lots of unrelated changes, as
nixpkgs
tends to do, as outlined in https://discourse.nixos.org/t/bumping-flake-inputs-bisecting-input-repo-for-relevant-changelog-entries/25619/7?u=nomeata.The text was updated successfully, but these errors were encountered: