-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README is confusing about running on PRs #80
Comments
The section isn't redundant, it just doesn't explain the use-case very clearly. The idea is that the action might included in a normal CI workflow that is run on pushes & PRs, (instead of just schedule). If the workflow is run on PRs, you probably want to skip the update step. The example doesn't include a fleshed out workflow (complete with other jobs/steps), so it looks a bit silly at first glance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The README is confusing (or perhaps confused) about running the action on PRs.
AFAIU the comment is correct and that specification will trigger on every pull-request; while the section is about not triggering on pull-requests. I might not understand what the auther intended to say but the other examples don't have the
on: pull_request:
and will not trigger on PRs; so maybe this section is redundant.The text was updated successfully, but these errors were encountered: