Add skeleton pages for user dashboard routes #156
Conversation
| @@ -0,0 +1,21 @@ | |||
| import { Heading, Text, Link } from '@chakra-ui/react'; | |||
There was a problem hiding this comment.
What are the rules about using Chakra UI Link vs. Remix Link? I wonder if we should prefer the router's link component?
There was a problem hiding this comment.
Oh, I simply used a Link here to render a <a> element which links to #114 . This is so that anyone working on the page can see where it came from. I felt the on other pages it was more obvious what they were about
|
Should we have a separate heading page so we don't have to recycle it for each route? |
You mean a separate component for the header that appear on the figma designs?
|
yeah... I was wondering how you'll be handling displaying the header across all the routes? |
Hmm, yea I hadn't thought of that. I will need to take a look to understand the best way to do this |
|
I have added a common header component for both |
app/routes/certificates.tsx
Outdated
| export default function CertificatesRoute() { | ||
| return ( | ||
| <div> | ||
| <Header /> |
There was a problem hiding this comment.
Probably this can be put higher in the router order, since every page will have this header, no? I'd do what you're doing here at the very top of the hierarchy, and render all the other routes into the outlet.
There was a problem hiding this comment.
would rendering it at the top affect the login page?
There was a problem hiding this comment.
True, need to put it in the right spot. We could also decide to always show the header, and remove the user info from the right. Remix has useMatches() that lets you get data loaded in any route layer, which you can use to get a user object or something without passing it around via props. We could use this to know if the user is logged in or not, and change how we show things.
There was a problem hiding this comment.
There is also a way to do this purely based on the routes folder structure. I found this useful blog about it.
I have changed it so the header will be display on all the routes except login
There was a problem hiding this comment.
Neat, I didn't know about this.
Resolves #138
Added basic pages for the following routes (as mentioned in the issue):
/domains/domains/new/domains/:id/certificate/certificate/instructionsAlso added a component for the header that will display on top of these pages. See image here
These are basic pages which can be styled later based on the figma designs
Steps to test