Add interface to DNS and DB

[Genne23v]

Closes #151
I wrote a long detailed change summary here, but I hit a wrong button and lost it all. This is not a client interface as I thought this is too big to be a direct interface to client. Please let me know if I took a wrong approach.

• createUserDomain() => Create a record in Route 53 and DB and return created record. If type, name, value exists, it declines to add it to DB.
• updateUserDomain()
• deleteUserDomain()
• removeIfExpired() => Remove a record when it's expired
• isDomainBeingExpired()
• isDomainExpired()

Quick high level review would be much appreciated!

[humphd]

Nice work @Genne23v. It's great how you're working through hard problems, creating APIs, and writing tests.

I've done a first pass through this code. I'll do more after you've had a chance to fix these.

[Genne23v]

@humphd I thought this might be a lot of rework. It's good to know that I'm on the right path. I will thoroughly review the whole code again to minimize the iteration of review.

[humphd]

I thought this might be a lot of rework. It's good to hear that I'm on the right path. I will thoroughly review the whole code again to reduce the amount of review.

I think it might be useful to hash out APIs in Issues before you dive in, since it means more work for you to change things around. However, I'm also pleased to see you pushing so hard on this DNS code.

I do want to change a bunch of things here, but we can do it starting from what you have. I'd avoid changing the tests too much at this point, until we figure out the right API.

[humphd]

Let me know when I should re-review this.

[Genne23v]

@humphd Yes, please review my updated PR.

[humphd]

@humphd Yes, please review my updated PR.

When you want someone to re-review, you have to click this refresh button:

[humphd]

This is really close! A few more simplifications and optimizations.

[humphd]

Almost there...

[humphd]

Few small things, but it looks great. If you want to move this stuff to new issues so we don't block this, that's fine too.

[ghost]

LGTM