Tweak login styles #187
Merged
Tweak login styles #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humphd
added
enhancement
Ririio
reviewed
Feb 13, 2023
| @@ -20,18 +20,18 @@ export async function loader({ request }: LoaderArgs) { | |||
|
|
|||
| function Document({ children }: { children: React.ReactNode }) { | |||
| return ( | |||
| <html lang="en"> | |||
app/routes/login.tsx
Outdated
| @@ -16,20 +16,22 @@ export const action = async ({ request }: ActionArgs) => { | |||
|
|
|||
| export default function Login() { | |||
| return ( | |||
| <Center height="container.md" marginTop="16"> | |||
| <Center height="full"> | |||
There was a problem hiding this comment.
Should we also consider resizing the container and its contents to allow a much more responsive login page? Or is that not what we're going for with this pr? Currently at lower res the contents aren't properly sized
|
@Ririio Great feedback. I've added Mobile
Desktop
|
|
@Ririio I can't merge this until you accept the invite to the new team and get write access. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes a few adjustments to the login and root routes.
min-heighton thehtmlandbodyso they always fill 100% of the available hightHere's what it looks like, but you really need to try in a window you can resize: