Making header responsive #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding margin for certifacate and domain
|
I really like what you've done. There is still some bug happening at the 0:28 mark of your video, though. One of the breakpoints is wrong.
|
oh no I noticed that too, but it's not from the code. Sometimes that can happen when I change resolution on the dev tool. If I try it again with the same format it works as intended 2023-02-14.11-21-50.mp4 |
humphd
approved these changes
Feb 14, 2023
Genne23v
approved these changes
Feb 15, 2023
cychu42
pushed a commit
to cychu42/starchart
that referenced
this pull request
Feb 15, 2023
adding margin for certifacate and domain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pr in reference to #202
I added a video demo to demonstrate what it does for different resolution
2023-02-14.10-55-16.mp4
I added a 'hamburger' state to accommodate for having two links. I was thinking on whether I should just turn it into an icon, but decided that it's for the best to have the name also be shown to avoid confusion.
I decided to remove the user name at a lower res, and was thinking on whether I should add it as a
MenuItemor not...