feat: Queue worker for order creation #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
Ririio
reviewed
Feb 22, 2023
cychu42
reviewed
Feb 22, 2023
humphd
reviewed
Feb 22, 2023
There was a problem hiding this comment.
I was able to run this locally, and the steps I took where:
npx prisma db push --force-reset
npm run db:seedIt might be good to file an issue to add a db:reset script to package.json for the future. I didn't know about being able to do this.
After the db was setup, I went to http://localhost:8080/dev and clicked Request Certificate, and the server logs show the flow happening.
I think this is looking good. Made a few comments/questions.
| logger.info(`Adding challenge to DNS`, { domain, challengeKey }); | ||
|
|
||
| /** | ||
| * TODO actually add challenge to DNS |
There was a problem hiding this comment.
It would be cool to connect this to @Genne23v's code soon. It would be good to get you two to start thinking about how we're going to connect the various flows that you're building together.
cychu42
approved these changes
Feb 23, 2023
Genne23v
pushed a commit
to Genne23v/starchart
that referenced
this pull request
Feb 25, 2023
* feat: Queue worker for order creation * fix: Front-end to match db schema * fix: based on review comments
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #168