Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dev run script for windows #267

Merged
merged 1 commit into from
Feb 23, 2023
Merged

Fix dev run script for windows #267

merged 1 commit into from
Feb 23, 2023

Conversation

Eakam1007
Copy link
Contributor

@Eakam1007 Eakam1007 commented Feb 22, 2023 •
edited
Loading

Fixes #266

Added cross-env to script so that npm run dev works on windows

@Eakam1007 Eakam1007 self-assigned this Feb 22, 2023
sfrunza13
sfrunza13 approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@sfrunza13 sfrunza13 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this what leads to the following?

 'SECRETS_OVERRIDE' is not recognized as an internal or external command,
operable program or batch file.

Edit: Yes, it is. Thank you.

@SerpentBytes SerpentBytes self-requested a review February 23, 2023 00:12
@Eakam1007 Eakam1007 merged commit 52298b5 into DevelopingSpace:main Feb 23, 2023
@Eakam1007 Eakam1007 deleted the issue-266 branch February 23, 2023 00:15
@humphd
Copy link
Contributor

humphd commented Feb 23, 2023

Thanks for catching this and the fix, @Eakam1007!

Genne23v pushed a commit to Genne23v/starchart that referenced this pull request Feb 25, 2023
@Eakam1007 @Genne23v
Add cross-env to dev script (DevelopingSpace#267)
177cdf8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SerpentBytes SerpentBytes SerpentBytes approved these changes

@sfrunza13 sfrunza13 sfrunza13 approved these changes

Assignees

@Eakam1007 Eakam1007

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run dev does not work on windows
4 participants
@Eakam1007 @humphd @SerpentBytes @sfrunza13