Feat: integrate domain delete + renew with DB + tooltips #276
Conversation
- Adds integration of deleting domain - Add integration of renewing domain (expiry date + 6 months) - Add tooltips for action buttons - Add loading on table row action submission
Myrfion
requested review from
humphd,
Ririio,
SerpentBytes,
Eakam1007,
cychu42 and
a user
app/routes/__index/domains/index.tsx
Outdated
| const newExpiresAt = new Date(record.expiresAt); | ||
| newExpiresAt.setMonth(newExpiresAt.getMonth() + 6); | ||
|
|
||
| await updateRecordById( |
There was a problem hiding this comment.
This signature is extremely hard to use and maintain. Please pass in an object instead. You can check the certificate and record models for an example if you would like to
app/routes/__index/domains/index.tsx
Outdated
| ); | ||
| } | ||
| } else if (request.method === 'DELETE') { | ||
| await deleteRecordById(formalizedID); |
There was a problem hiding this comment.
If I understand this correctly, this is now what we should do.
If you take the record and delete it from the FE, that will not actually delete the record from route53, it will only delete our knowledge of it.
Instead, we should kick off a worker, that removes the record from route53, then delete it from the db as well
There was a problem hiding this comment.
To be honest, I'd just add a TODO into the code instead of this DB tie and ship this PR.
If a PR is not merged, it's constant work to resolve conflicts and keep it up to date and ready to merge while others are working on the same piece of code
Here is what the table row in the loading state looks like:
Closes #271 #272 #205