Add baseDomain to user #298
Conversation
As far as I understand it, speaking to ITS, it's the only thing that might be included that we care about (e.g., they use |
| @@ -40,7 +64,3 @@ export async function updateUserByUsername( | |||
| }, | |||
| }); | |||
| } | |||
|
|
|||
| export async function deleteUserByUsername(username: User['username']) { | |||
There was a problem hiding this comment.
Just curious, do we not need the delete or update functionality here?
There was a problem hiding this comment.
We aren't the source of truth on user info, we just store it for lookup purposes. We don't really manage user info. I can't think of a case where we'd do update or delete, can you? Maybe when we add the admin UI, but currently this is dead code, and dead code should get removed.
Fixes #253
In a few recent issues and PRs, I've noticed that we need to have access to the user's base domain (i.e.,
{username}.{root-domain}). For example, @Genne23v needs it in #289.I've adjusted our code so that a
Useris a combination of a PrismaUser(e.g., what is in the db), but also adds a dynamically generated property.baseDomain, which is the user's base domain. ThisbaseDomainis then available in the front-end using theuseUser()hook.I have an example of how to use it by including it in the New Domain form, which we discussed in the early UI meetings:
Now a user only has to enter the first part of the name, and we build the rest for them.
I've also dealt with usernames including a
., and removed it. To make it easier to test this (until @cychu42 gets our db tests working in #238), I've updated the userhansoloto behan.solo. In the screenshot above, you can see that the.was removed from the username. I've left the username untouched in the db, though, so it matches what Seneca has (i.e., I only remove the.from the base domain we use for such a user).Tagging a few people for reviews, since this touches a bunch of back-end and front-end code.