Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Landing Page UI | Access Denied/Login Failed Page #310

Merged
merged 7 commits into from
Mar 10, 2023

Conversation

Ririio
Copy link
Contributor

@Ririio Ririio commented Mar 9, 2023

For Issue: #292 #204

  • This pull request added a new UI for the landing page, with two new cards, website name and description.
  • I tweaked the header to now have "absolute" position. This is to prevent overflowing when developers want to set the height to "full"
  • The previous "Loading" file, has now change to "DisplayPage"
    • This is to have a more global message page
  • I remove the name of the website on the header, and moved it to the landing page instead
    • The icon feels much cleaner compared to a text with aligning
  • Domain and Certficate cards displays a brief description of what they are
    • A button for the "information" page
    • A button to redirect them to the main page

Demo #292

2023-03-09.09-59-59.mp4

Demo #204

2023-03-09.10-00-23.mp4

@Ririio Ririio added category: front end Front end part of our web service area: web Web development related things [front end/back end] labels Mar 9, 2023
@Ririio Ririio added this to the Milestone 0.5 milestone Mar 9, 2023
@Ririio Ririio changed the title UI Implementation - Landing Page | Minor adjustments Landing Page UI | Access Denied/Login Failed Page Mar 9, 2023
app/routes/login.tsx Outdated Show resolved Hide resolved
app/routes/login.tsx Outdated Show resolved Hide resolved
app/components/header.tsx Show resolved Hide resolved
app/components/header.tsx Outdated Show resolved Hide resolved
</Flex>
<ButtonGroup size={{ base: 'sm', md: 'md' }} gap="5">
<Button as={Link} to={{ pathname: `${path}/instructions` }}>
Information
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we name this Help or Instructions instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think Instructions is fine if it contains other info aside from actual instructions?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Instructions would be fine since the path itself is /instructions

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alrighty

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, did you end up not changing this?

app/routes/__index/index.tsx Outdated Show resolved Hide resolved
app/routes/__index/index.tsx Outdated Show resolved Hide resolved
app/components/header.tsx Outdated Show resolved Hide resolved
SerpentBytes
SerpentBytes previously approved these changes Mar 9, 2023
humphd
humphd previously requested changes Mar 9, 2023
Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great.

One thing about the 2 buttons in the cards. I think we should consider making the entire card clickable, and not have any buttons at all. I'd move the "Instructions" to the individual pages and include it as a link in the intro paragraphs on those pages (i.e., to learn more, see these instructions...).

@Ririio
Copy link
Contributor Author

Ririio commented Mar 9, 2023

One thing about the 2 buttons in the cards. I think we should consider making the entire card clickable, and not have any buttons at all. I'd move the "Instructions" to the individual pages and include it as a link in the intro paragraphs on those pages (i.e., to learn more, see these instructions...).

That was my first iteration of the card actually, I spent a few hours trying to make it look better, but having a title and desc just doesn't work unless I add effects. After a while I decided to go with buttons to make it not empty

@Eakam1007
Copy link
Contributor

Eakam1007 commented Mar 9, 2023

I think you can wrap the entire card or its heading in a Link Chakra UI component.

@Ririio
Copy link
Contributor Author

Ririio commented Mar 9, 2023

I think you can wrap the entire card in a Link Chakra UI component

I did create the first iteration as a clickable card, but I decided against it due to not having enough values to justify its existence. Unless we add hover effects, it just doesn't look right having a card with only a title and desc

app/components/header.tsx Outdated Show resolved Hide resolved
Eakam1007
Eakam1007 previously approved these changes Mar 9, 2023
Copy link
Contributor

@Eakam1007 Eakam1007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could change the button text from Information to something else if you like but looks good to me

@humphd
Copy link
Contributor

humphd commented Mar 10, 2023

One thing about the 2 buttons in the cards. I think we should consider making the entire card clickable, and not have any buttons at all. I'd move the "Instructions" to the individual pages and include it as a link in the intro paragraphs on those pages (i.e., to learn more, see these instructions...).

That was my first iteration of the card actually, I spent a few hours trying to make it look better, but having a title and desc just doesn't work unless I add effects. After a while I decided to go with buttons to make it not empty

OK. I'd still move the "instructions" bit to the page itself, and only have a single call-to-action button for each card.

Copy link
Contributor

@Eakam1007 Eakam1007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things:

  • You should remove the unused ButtonGroup import in langing-page-card.tsx Line 1
  • Would it be better if the button took the entire width of the card?
    image
  • Also, you should add a Link to the instructions page in the card description

@humphd
Copy link
Contributor

humphd commented Mar 10, 2023

For the buttons, I would:

  1. centre them in the card
  2. Use "Manage" vs. "View" for the verb: "Manage DNS Records" and "Manage SSL Certificate"

@Ririio Ririio requested a review from Eakam1007 March 10, 2023 15:14
@ghost
Copy link

ghost commented Mar 10, 2023

@Ririio
Maybe I'm just missing it, but what is the license for that SVG image? Where is it from, what conditions is it come with? IMO we should document this (maybe a file next to the svg or something)

@Ririio
Copy link
Contributor Author

Ririio commented Mar 10, 2023

@Ririio Maybe I'm just missing it, but what is the license for that SVG image? Where is it from, what conditions is it come with? IMO we should document this (maybe a file next to the svg or something)

https:/DevelopingSpace/starchart/blob/main/app/assets/LICENSE

The license is under here.
They provide you with the text info here https://undraw.co/license

@ghost
Copy link

ghost commented Mar 10, 2023

Thanks, approved!

@Ririio Ririio merged commit b61a3f0 into DevelopingSpace:main Mar 10, 2023
@Ririio Ririio deleted the issue-204 branch March 10, 2023 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: web Web development related things [front end/back end] category: front end Front end part of our web service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Access Denied / Login Failed Page Implement landing-page experience
4 participants