-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Landing Page UI | Access Denied/Login Failed Page #310
Conversation
</Flex> | ||
<ButtonGroup size={{ base: 'sm', md: 'md' }} gap="5"> | ||
<Button as={Link} to={{ pathname: `${path}/instructions` }}> | ||
Information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we name this Help
or Instructions
instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think Instructions
is fine if it contains other info aside from actual instructions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think Instructions
would be fine since the path itself is /instructions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alrighty
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, did you end up not changing this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great.
One thing about the 2 buttons in the cards. I think we should consider making the entire card clickable, and not have any buttons at all. I'd move the "Instructions" to the individual pages and include it as a link in the intro paragraphs on those pages (i.e., to learn more, see these instructions...
).
That was my first iteration of the card actually, I spent a few hours trying to make it look better, but having a title and desc just doesn't work unless I add effects. After a while I decided to go with buttons to make it not empty |
I think you can wrap the entire card or its heading in a |
I did create the first iteration as a clickable card, but I decided against it due to not having enough values to justify its existence. Unless we add hover effects, it just doesn't look right having a card with only a title and desc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could change the button text from Information
to something else if you like but looks good to me
OK. I'd still move the "instructions" bit to the page itself, and only have a single call-to-action button for each card. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the buttons, I would:
|
@Ririio |
https:/DevelopingSpace/starchart/blob/main/app/assets/LICENSE The license is under here. |
Thanks, approved! |
For Issue: #292 #204
Demo #292
2023-03-09.09-59-59.mp4
Demo #204
2023-03-09.10-00-23.mp4