Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate domain create,delete,prolong with server + minor UI hintsgs #324

Merged
merged 13 commits into from
Mar 15, 2023
Merged

Integrate domain create,delete,prolong with server + minor UI hintsgs #324

merged 13 commits into from
Mar 15, 2023

Conversation

Myrfion
Copy link
Contributor

@Myrfion Myrfion commented Mar 12, 2023

Changes

  • integration for domain creation with server
  • integration for domain deletion and prolong
  • add refresh domains button
  • remove records from seeding, because they are invalid because they are not connected to any hosted zone and in development, it is created at the start of dev environment, so when you seed db it doesn't exist yet. Since the creation of records is available now with UI people can do that for testing purposes. Invalid records provide more confusion than benefit (because you can't perform server-side operations with them properly) so removing them
  • Highlight names based on the domains table
  • Add react-icons package for icons, this is the one that chakra show as the example of 3-rd party package so I think it should be good, the chakra's icons library itself is very poor

The screen recording of how it looks now is attached

Screen.Recording.2023-03-11.at.19.12.57.mov

closes #280 #272

@Myrfion Myrfion self-assigned this Mar 12, 2023
@humphd humphd added this to the Milestone 0.6 milestone Mar 12, 2023
Ririio
Ririio reviewed Mar 12, 2023
View reviewed changes
app/queues/dns/dns-flow.server.ts Outdated Show resolved Hide resolved
app/queues/dns/dns-flow.server.ts Show resolved Hide resolved
app/routes/__index/domains/index.tsx Outdated Show resolved Hide resolved
app/routes/__index/domains/index.tsx Outdated Show resolved Hide resolved
app/routes/__index/domains/index.tsx Outdated Show resolved Hide resolved
app/routes/__index/domains/index.tsx Show resolved Hide resolved
SerpentBytes

This comment was marked as duplicate.

Sign in to view

@SerpentBytes SerpentBytes self-requested a review March 12, 2023 23:19
humphd
humphd requested changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm excited to see this happening!

app/components/domains-table.tsx Outdated Show resolved Hide resolved
app/components/domains-table.tsx Outdated Show resolved Hide resolved
app/components/domains-table.tsx Outdated Show resolved Hide resolved
app/queues/dns/dns-flow.server.ts Show resolved Hide resolved
app/routes/__index/domains/index.tsx Outdated Show resolved Hide resolved
app/routes/__index/domains/index.tsx Outdated Show resolved Hide resolved
app/routes/__index/domains/index.tsx Outdated Show resolved Hide resolved
app/routes/__index/domains/index.tsx Outdated Show resolved Hide resolved
app/routes/__index/domains/index.tsx Outdated Show resolved Hide resolved
prisma/seed.ts Show resolved Hide resolved
humphd
humphd requested changes Mar 13, 2023
View reviewed changes
app/components/domains-table.tsx Outdated Show resolved Hide resolved
app/components/domains-table.tsx Outdated Show resolved Hide resolved
app/models/record.server.ts Outdated Show resolved Hide resolved
humphd
humphd requested changes Mar 13, 2023
View reviewed changes
app/components/domains-table.tsx Outdated Show resolved Hide resolved
@Myrfion Myrfion requested a review from humphd March 14, 2023 01:18
humphd
humphd requested changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing from me, and I think this is good. Fix the other issues people are calling out, too.

app/components/dns-record/dns-record-name.tsx Outdated Show resolved Hide resolved
Ririio
Ririio approved these changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@Ririio Ririio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any other issues

@Myrfion Myrfion merged commit 5445a01 into main Mar 15, 2023
@Myrfion Myrfion deleted the feature/domains-server-integration branch March 15, 2023 14:18
@Myrfion Myrfion mentioned this pull request Mar 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SerpentBytes SerpentBytes SerpentBytes left review comments

@humphd humphd humphd approved these changes

@Ririio Ririio Ririio approved these changes

@Eakam1007 Eakam1007 Awaiting requested review from Eakam1007

@cychu42 cychu42 Awaiting requested review from cychu42

@Genne23v Genne23v Awaiting requested review from Genne23v

Assignees

@Myrfion Myrfion

Labels
None yet
Projects
None yet
Milestone
Milestone 0.6
Development

Successfully merging this pull request may close these issues.

Add appropriate connect to records service to make deletion work
5 participants
@Myrfion @humphd @Ririio @SerpentBytes @Genne23v