Add docker-staging.yml for deployment to staging #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humphd
added
category: deployment
sfrunza13
previously approved these changes
Mar 14, 2023
|
Rebased on the other fixes we did this morning. If this passes tests, I think it's ready to land. |
|
OK, this is all green, ready for review! |
sfrunza13
previously approved these changes
Mar 14, 2023
sfrunza13
previously approved these changes
Mar 14, 2023
humphd
changed the title
SAML fixes based on testing with staging Use HOSTNAME=http://host.docker.internal:8080 so tests work
SerpentBytes
approved these changes
Mar 17, 2023
humphd
commented
Mar 17, 2023
| - HOSTNAME=https://mycustomdomain-dev.senecacollege.ca | ||
| - AWS_ROUTE53_HOSTED_ZONE_ID=Z0228625ICAL609E0BBT | ||
| - [email protected] | ||
| - LETS_ENCRYPT_DIRECTORY_URL=https://acme-staging-v02.api.letsencrypt.org/directory |
There was a problem hiding this comment.
Need to confirm this with @dadolhay.
There was a problem hiding this comment.
I'm going to land, but if this is needing to get changed, let me know if a follow up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #43
This defines a Docker Swarm Stack for staging. Some notes on what's included:
I'm going to manually test this on staging and report back with fixes and info on how it goes.