Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Took array and made it string #337

Merged
merged 1 commit into from
Mar 14, 2023
Merged

Took array and made it string #337

merged 1 commit into from
Mar 14, 2023

Conversation

sfrunza13
Copy link
Contributor

joined group claims into string, added array of groups to hans since he's not in seed
Closes #336

humphd
humphd approved these changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test logging in as one of our built-in admins locally? Does that work?

The code looks good.

@sfrunza13
Copy link
Contributor Author

This is why I added array of groups to hans, I tested and logged the string that the join creates before pushing

@sfrunza13 sfrunza13 merged commit 4453612 into DevelopingSpace:main Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humphd humphd humphd approved these changes

@Ririio Ririio Ririio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flatten groups array
3 participants
@sfrunza13 @humphd @Ririio