Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ACME Challenge completer worker #358

Merged
2 commits merged into from Mar 17, 2023
Merged

feat: ACME Challenge completer worker #358

2 commits merged into from Mar 17, 2023

Conversation

ghost
Copy link

@ghost ghost commented Mar 16, 2023

The implemented worke:

  • runs after we verify that the DNS challenge record has been propagated in Route53
  • completes all challenges with the ACME provider

Closes #170

@ghost ghost requested review from humphd, SerpentBytes, Genne23v and sfrunza13 March 16, 2023 19:52
humphd
humphd previously approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one nit.

app/queues/certificate/challenge-completer-worker.server.ts Outdated Show resolved Hide resolved
Genne23v
Genne23v approved these changes Mar 17, 2023
View reviewed changes
Copy link
Contributor

@Genne23v Genne23v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I think I should add some log to DNS module too.

@Genne23v Genne23v assigned ghost Mar 17, 2023
@ghost ghost merged commit d0d3e46 into DevelopingSpace:main Mar 17, 2023
@ghost ghost deleted the issue-170 branch March 18, 2023 00:43
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SerpentBytes SerpentBytes Awaiting requested review from SerpentBytes

@sfrunza13 sfrunza13 Awaiting requested review from sfrunza13

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create queue and worker for ACME challenge completion
3 participants
@humphd @Genne23v @denke8