refactor: record 'name' to 'subdomain' #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humphd
approved these changes
Mar 18, 2023
There was a problem hiding this comment.
This is a great fix, and simplifies/clarifies a bunch of the API for DNS stuff.
@cychu42, @dadolhay we'll have to figure out how I handle the DB update on staging, since I don't think prisma db push will work here with existing data in the table?
ghost
approved these changes
Mar 18, 2023
|
This change is awesome @SerpentBytes, thank you for implementing it! @humphd It would probably just delete that column and recreate a new one instead. Locally, we can drop the complete db alter table `record` rename column `name` to `subdomain`; |
|
OK, staging is updated with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #377
Steps to Test
npm run setup