Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update vitest config #410

Merged
merged 5 commits into from
Mar 23, 2023
Merged

Update vitest config #410

merged 5 commits into from
Mar 23, 2023

Conversation

Eakam1007
Copy link
Contributor

@Eakam1007 Eakam1007 commented Mar 22, 2023 •
edited
Loading

Resolves #134

Make a few changes to our vitest config:

  • Added a test:coverage script to run tests with coverage. This shows the coverage report in the terminal and generated a html report in coverage folder
  • Removed c8 and replaced it with istanbul which will be used to generate the coverage. This was mainly done because there were issues getting the default c8 to properly generate coverage as no files were displayed in the coverage. Even with the all files setting, none of the files showed anything being covered by tests
  • Added coverage folder to .gitignore
  • Updated watchExclude to exclude our mysql-data folder
  • Removed redundant include in vitest.config

@Eakam1007 Eakam1007 added category: testing Unit tests, end to end tests area: devOps Services/tools that are not our main functionality, but help the project labels Mar 22, 2023
@Eakam1007 Eakam1007 added this to the Milestone 0.7 milestone Mar 22, 2023
@Eakam1007 Eakam1007 self-assigned this Mar 22, 2023
@Eakam1007 Eakam1007 changed the title 134 update vitest config Update vitest config Mar 22, 2023
humphd
humphd approved these changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was worth doing, thanks for taking it on.

@Eakam1007 Eakam1007 marked this pull request as ready for review March 22, 2023 16:11
@Eakam1007 Eakam1007 mentioned this pull request Mar 22, 2023
Closed
@cychu42
Copy link
Contributor

cychu42 commented Mar 23, 2023

As discussed in the meeting, I think it would be beneficial to see what files are not covered in app/models by unit tests.

sfrunza13
sfrunza13 approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@sfrunza13 sfrunza13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this in :)

@Eakam1007
Copy link
Contributor Author

As discussed in the meeting, I think it would be beneficial to see what files are not covered in app/models by unit tests.

I have filed #420 to add coverage for playwright tests, and I am planning to update this coverage based on that

@Eakam1007 Eakam1007 merged commit ddda047 into DevelopingSpace:main Mar 23, 2023
@Eakam1007 Eakam1007 deleted the 134-update-vitest-config branch March 23, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humphd humphd humphd approved these changes

@sfrunza13 sfrunza13 sfrunza13 approved these changes

Assignees

@Eakam1007 Eakam1007

Labels
area: devOps Services/tools that are not our main functionality, but help the project category: testing Unit tests, end to end tests
Projects
None yet
Milestone
Milestone 0.7
Development

Successfully merging this pull request may close these issues.

Confirm our Vitest config and unit test setup
4 participants
@Eakam1007 @cychu42 @humphd @sfrunza13