Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide table if no DNS Records exist #429

Merged
merged 2 commits into from
Mar 24, 2023
Merged

Hide table if no DNS Records exist #429

merged 2 commits into from
Mar 24, 2023

Conversation

Eakam1007
Copy link
Contributor

Resolves #403

This changes the DNS Records tables so that:

  • The text container takes up the same width as the DNS Records table. This was done because the DNS Records table takes up the full width
  • If there are no DNS Records, a create button will be displayed in the center of the page

Without DNS Records

image

With DNS Records

image

@Eakam1007 Eakam1007 added category: front end Front end part of our web service area: web Web development related things [front end/back end] labels Mar 23, 2023
@Eakam1007 Eakam1007 added this to the Milestone 0.7 milestone Mar 23, 2023
@Eakam1007 Eakam1007 self-assigned this Mar 23, 2023
Ririio
Ririio approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@Ririio Ririio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, didn't see any issue

@Eakam1007 Eakam1007 merged commit 5d869c3 into DevelopingSpace:main Mar 24, 2023
@Eakam1007 Eakam1007 deleted the 403-create-no-dns-records branch March 24, 2023 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humphd humphd humphd approved these changes

@Ririio Ririio Ririio approved these changes

@Myrfion Myrfion Awaiting requested review from Myrfion

Assignees

@Eakam1007 Eakam1007

Labels
area: web Web development related things [front end/back end] category: front end Front end part of our web service
Projects
None yet
Milestone
Milestone 0.7
Development

Successfully merging this pull request may close these issues.

First run experience for DNS Records page
3 participants
@Eakam1007 @humphd @Ririio