Fix html, body styling, update head #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Myrfion
previously approved these changes
Mar 24, 2023
Eakam1007
previously approved these changes
Mar 24, 2023
Eakam1007
added
area: web
SerpentBytes
previously approved these changes
Mar 24, 2023
humphd
dismissed stale reviews from SerpentBytes, Eakam1007, and Myrfion
via
1e6a61e
humphd
force-pushed
the
doctype-styles-fix
branch
from
9d5a4ea
to
1e6a61e
Compare
|
I had to modify this a bit to work on the login page. |
SerpentBytes
approved these changes
Mar 24, 2023
Eakam1007
approved these changes
Mar 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was testing the site in Lighthouse, and it was complaining that we didn't have a
<!DOCTYPE html>. We do have it, but the way that the styles forhtmlandbodywere being done by Chakra UI, it was putting a<style>tag outside the document. This fixes it.I also updated the
<head>to fix the title and description.