Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create admin page with layout #451

Merged
merged 1 commit into from
Apr 1, 2023
Merged

Create admin page with layout #451

merged 1 commit into from
Apr 1, 2023

Conversation

Myrfion
Copy link
Contributor

@Myrfion Myrfion commented Mar 27, 2023

  • add admin route
  • create metric card component and use it for total number of records, certificates and users
  • create text field for search
  • create users table with some mock data

image

Closes #23

@Myrfion Myrfion added category: front end Front end part of our web service area: web Web development related things [front end/back end] labels Mar 27, 2023
@Myrfion Myrfion added this to the Milestone 0.8 milestone Mar 27, 2023
@Myrfion Myrfion self-assigned this Mar 27, 2023
Ririio
Ririio reviewed Mar 27, 2023
View reviewed changes
app/components/admin/admin-metric-card.tsx Outdated Show resolved Hide resolved
app/components/admin/admin-metric-card.tsx Outdated Show resolved Hide resolved
app/routes/__index/admin/index.tsx Outdated Show resolved Hide resolved
Eakam1007
Eakam1007 reviewed Mar 27, 2023
View reviewed changes
app/mock/users.ts Outdated Show resolved Hide resolved
app/routes/__index/admin/index.tsx Outdated Show resolved Hide resolved
humphd
humphd requested changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great, nice work! I've left some initial feedback.

app/components/admin/users-table.tsx Outdated Show resolved Hide resolved
app/components/admin/users-table.tsx Outdated Show resolved Hide resolved
app/components/admin/users-table.tsx Outdated Show resolved Hide resolved
app/components/admin/users-table.tsx Outdated Show resolved Hide resolved
app/mock/users.ts Outdated Show resolved Hide resolved
app/routes/__index/admin/index.tsx Outdated Show resolved Hide resolved
app/routes/__index/admin/index.tsx Outdated Show resolved Hide resolved
@Myrfion
Copy link
Contributor Author

Myrfion commented Mar 28, 2023

@humphd @humphd @Ririio

Did a big update with server-side integration, here is what it looks like now:

Screen.Recording.2023-03-28.at.17.14.50.mov

humphd
humphd requested changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

app/components/admin/users-table.tsx Outdated Show resolved Hide resolved
app/models/certificate.server.ts Show resolved Hide resolved
app/models/dns-record.server.ts Outdated Show resolved Hide resolved
app/models/dns-record.server.ts Outdated Show resolved Hide resolved
app/models/dns-record.server.ts Outdated Show resolved Hide resolved
app/routes/__index/admin/index.tsx Outdated Show resolved Hide resolved
app/routes/__index/admin/index.tsx Outdated Show resolved Hide resolved
Genne23v
Genne23v requested changes Mar 29, 2023
View reviewed changes
app/routes/__index/admin/index.tsx Outdated Show resolved Hide resolved
Genne23v
Genne23v previously approved these changes Mar 29, 2023
View reviewed changes
@Genne23v Genne23v self-requested a review March 29, 2023 15:37
@Myrfion
Copy link
Contributor Author

Myrfion commented Mar 29, 2023

@humphd filed the follow-up of the user certificate status

#473

@humphd
Copy link
Contributor

humphd commented Mar 29, 2023

@humphd filed the follow-up of the user certificate status

#473

Great. Please flag me when you want a review again.

@Myrfion
Copy link
Contributor Author

Myrfion commented Mar 29, 2023

@humphd filed the follow-up of the user certificate status
#473

Great. Please flag me when you want a review again.

I already did an update so please do it when you can, thanks

humphd
humphd requested changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small thing and this is good!

app/models/dns-record.server.ts Outdated Show resolved Hide resolved
app/models/dns-record.server.ts Outdated Show resolved Hide resolved
@Myrfion
Copy link
Contributor Author

Myrfion commented Mar 29, 2023

@humphd updated, please rereview it

humphd
humphd previously approved these changes Mar 29, 2023
View reviewed changes
Genne23v
Genne23v previously approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@Genne23v Genne23v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@humphd
Copy link
Contributor

humphd commented Mar 30, 2023

@Myrfion the CI seems stuck here, can you please rebase so we can get this through testing and hopefully landed soon?

@Genne23v Genne23v dismissed stale reviews from humphd and themself via 0700472 March 30, 2023 20:35
humphd
humphd previously approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for re-running this @Genne23v, looks good to me. If you're OK with it, can you land please?

@humphd
Copy link
Contributor

humphd commented Mar 30, 2023

@Myrfion please squash all that into 1 commit vs. 8.

@Myrfion Myrfion requested review from Genne23v and humphd March 30, 2023 20:46
Genne23v
Genne23v previously approved these changes Mar 30, 2023
View reviewed changes
humphd
humphd requested changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash this into a single commit. I'd like to get this landed soon.

@Eakam1007
Copy link
Contributor

Please squash this into a single commit. I'd like to get this landed soon.

I believe we could also squash when merging?

@humphd
Copy link
Contributor

humphd commented Mar 31, 2023

You can, but doing so means you can't also rebase, so you get a merge commit.

@Genne23v
Copy link
Contributor

Genne23v commented Apr 1, 2023

You can, but doing so means you can't also rebase, so you get a merge commit.

I carefully copied the code and squashed the commits. I think the PR is ready to go.

@humphd humphd merged commit 5ddbcb5 into main Apr 1, 2023
@humphd humphd deleted the feature/admin-page-layout branch April 1, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humphd humphd humphd approved these changes

@Genne23v Genne23v Genne23v approved these changes

@cychu42 cychu42 Awaiting requested review from cychu42

@SerpentBytes SerpentBytes Awaiting requested review from SerpentBytes

@sfrunza13 sfrunza13 Awaiting requested review from sfrunza13

@Ririio Ririio Awaiting requested review from Ririio

@Eakam1007 Eakam1007 Awaiting requested review from Eakam1007

Assignees

@Myrfion Myrfion

Labels
area: web Web development related things [front end/back end] category: front end Front end part of our web service
Projects
None yet
Milestone
Milestone 0.8
Development

Successfully merging this pull request may close these issues.

Add an Admin Dashboard page
5 participants
@Myrfion @humphd @Eakam1007 @Genne23v @Ririio