Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DNS record expiry date always being set to July #457

Merged
merged 1 commit into from
Mar 27, 2023
Merged

Fix DNS record expiry date always being set to July #457

merged 1 commit into from
Mar 27, 2023

Conversation

Eakam1007
Copy link
Contributor

Fixes #281

Currently, the expiry date for a DNS Record is always set to July. This PR changes this to set it to 6 months from current date instead.

Steps to test

  • Run app locally
  • Navigate to Records page
  • Create a new record
  • Check that expiry date is 6 months from now
  • Edit record's expiry date to less than 6 months using prima studio (npm run db:studio)
  • Click renew button
  • Check expiry date is 6 months from now

@Eakam1007 Eakam1007 added bug Something isn't working category: back end Back end part of our web service labels Mar 27, 2023
@Eakam1007 Eakam1007 added this to the Milestone 0.8 milestone Mar 27, 2023
@Eakam1007 Eakam1007 self-assigned this Mar 27, 2023
Genne23v
Genne23v approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@Genne23v Genne23v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My test results are good for both create/update.

@Eakam1007 Eakam1007 merged commit b612baa into DevelopingSpace:main Mar 27, 2023
@Eakam1007 Eakam1007 deleted the 281-fix-dns-record-expiry-date branch March 27, 2023 22:20
Genne23v pushed a commit to Genne23v/starchart that referenced this pull request Mar 29, 2023
@Eakam1007 @Genne23v
Fix dns record expiry date always being set to July (DevelopingSpace#457
d6120de 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humphd humphd humphd approved these changes

@Genne23v Genne23v Genne23v approved these changes

Assignees

@Eakam1007 Eakam1007

Labels
bug Something isn't working category: back end Back end part of our web service
Projects
None yet
Milestone
Milestone 0.8
Development

Successfully merging this pull request may close these issues.

Add appropriate connect to records service to make record prolonging work
3 participants
@Eakam1007 @humphd @Genne23v