Refactor to use database as DNS ground truth, remove DNS worker code #464
Conversation
|
There might be more code we can remove that I'm missing. Let me know if you see or think of anything. |
app/components/dns-records-table.tsx
Outdated
| @@ -121,7 +80,6 @@ export default function DnsRecordsTable(props: DnsRecordsTableProps) { | |||
| <Table variant="striped" colorScheme="gray"> | |||
| <Thead> | |||
| <Tr> | |||
| <Th /> | |||
| <Th>Subdomain</Th> | |||
There was a problem hiding this comment.
I think we should change this column name to DNS Record
There was a problem hiding this comment.
Good idea, I'll do that.
|
Updated to not use |
|
@Eakam1007 because this is so big, I'll get you to do your review too before I merge (and anyone else that wants to--let me know). |
Genne23v
added
category: DNS
Ah, indeed. Changing now... |
|
Updated to indicate that reconciler is needed after CRUD operations. |
| @@ -48,7 +49,11 @@ export async function createDnsRecord( | |||
| // Set expiration date 6 months from now | |||
| const expiresAt = dayjs().add(6, 'month').toDate(); | |||
|
|
|||
| return prisma.dnsRecord.create({ data: { ...data, expiresAt } }); | |||
| return prisma.dnsRecord.create({ data: { ...data, expiresAt } }).then((result) => { | |||
There was a problem hiding this comment.
should we extract it in a separate function?
(result) => {
// Flag the reconciler that an update will be needed
setIsReconciliationNeeded(true);
return result;
})Like flagReconciliationNeeded or something?
There was a problem hiding this comment.
Actually, I started to write it, and it's literally the same code. I'm not sure adding a new function does much for us here.
There was a problem hiding this comment.
It looks like setIsReconciliationNeeded() does the job of setting that flag.
Do we need it for |
No, that is only for our own system, telling when to delete the record Us deleting the record from db, will trigger the reconciler to delete it from Route53 |
|
Rebased and squashed. |
Fixes #440
This switches over to use the database as our source of truth for all DNS Record info. The reconciler is now responsible for making this happen in Route53, and we don't use DNS workers or direct calls anymore.
I've also fixed the bug where we didn't update the optional parts of a DNS Record in the db while editing.
I have to fix something with e2e tests, but I wanted to get this in fast, since it's blocking testing on Staging.