feat: Cleaning out obsolete challenge records, fixing certificate save #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
humphd,
Myrfion,
SerpentBytes,
Genne23v,
Eakam1007,
sfrunza13 and
cychu42
humphd
reviewed
Mar 29, 2023
humphd
previously approved these changes
Mar 30, 2023
|
@cychu42 can you review this please? |
|
Is this related to an issue? What is the context here? |
|
@Eakam1007 This is the last step in the cert creation process, removing the outdated DNS records |
Eakam1007
previously approved these changes
Mar 30, 2023
Co-authored-by: Eakam <[email protected]>
Eakam1007
approved these changes
Mar 30, 2023
|
@Eakam1007 Change accepted, thanks! |
humphd
approved these changes
Mar 30, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #248