Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add checks for deactivated users #487

Merged
merged 8 commits into from
Apr 1, 2023
Merged

Add checks for deactivated users #487

merged 8 commits into from
Apr 1, 2023

Conversation

Eakam1007
Copy link
Contributor

@Eakam1007 Eakam1007 commented Mar 31, 2023 •
edited
Loading

Resolves #394, resolves #308

This PR updates the requireUsername (and therefore also requireUser) function to logout the user if the user is deactivated.
This in turn ensures that no actions can be performed on routes where we use these functions as the user will be immediately logged out, and redirected to the login page.
It also updates the certificate workers to throw an unrecoverable error if the user is deactivated

@Eakam1007 Eakam1007 added category: certificates Creating certificates, encryption new feature Adding a new solution category: DNS A service about hosting domains category: authentication A service responsible for logging users in and maintaining their permissions based on credentials labels Mar 31, 2023
@Eakam1007 Eakam1007 self-assigned this Mar 31, 2023
@Eakam1007 Eakam1007 marked this pull request as ready for review March 31, 2023 00:37
@Eakam1007 Eakam1007 requested review from a user, humphd and Genne23v March 31, 2023 00:40
@humphd humphd requested a review from sfrunza13 March 31, 2023 01:22
humphd
humphd requested changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding our auth-expert @sfrunza13 for review too.

app/models/dns-record.server.ts Outdated Show resolved Hide resolved
app/session.server.ts Outdated Show resolved Hide resolved
@Eakam1007 Eakam1007 added this to the Milestone 0.8 milestone Mar 31, 2023
@Eakam1007 Eakam1007 requested a review from humphd March 31, 2023 21:02
humphd
humphd approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@Eakam1007 Eakam1007 merged commit 33a2329 into DevelopingSpace:main Apr 1, 2023
@Eakam1007 Eakam1007 deleted the 394-check-deactivated-users branch April 1, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humphd humphd humphd approved these changes

@sfrunza13 sfrunza13 sfrunza13 approved these changes

@Genne23v Genne23v Awaiting requested review from Genne23v

Assignees

@Eakam1007 Eakam1007

Labels
category: authentication A service responsible for logging users in and maintaining their permissions based on credentials category: certificates Creating certificates, encryption category: DNS A service about hosting domains new feature Adding a new solution
Projects
None yet
Milestone
Milestone 0.8
Development

Successfully merging this pull request may close these issues.

Add checks for a user being deactivated when jobs are run Allow users to be deactivated
3 participants
@Eakam1007 @humphd @sfrunza13