Make DNS Record form text more helpful #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humphd
force-pushed
the
dns-record-form-help
branch
from
11c23a2
to
f3cee1e
Compare
Genne23v
reviewed
Apr 3, 2023
Genne23v
requested changes
Apr 3, 2023
| > | ||
| <InputGroup> | ||
| <Input name="subdomain" defaultValue={dnsRecord?.subdomain} /> | ||
| <InputRightAddon children={`.${user.baseDomain}`} /> | ||
| </InputGroup> | ||
| <Tooltip label="Enter a name for the DNS Record: name"> | ||
| <InfoIcon color="#d9d9d9" fontSize="xl" /> |
There was a problem hiding this comment.
import InfoIcon, Tooltip need to be removed
humphd
force-pushed
the
dns-record-form-help
branch
from
f3cee1e
to
822491a
Compare
|
@Genne23v great suggestions! I've done both. |
Ririio
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In anticipation of having people do user testing on the app, I've added some more instructions/help text to the DNS Record form:
Let me know if you think I can further improve these messages