Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use journald log driver, update DEPLOY docs on logging #512

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

humphd
Copy link
Contributor

@humphd humphd commented Apr 4, 2023

Fixes #117

This switches Docker to use the journald log driver instead of the default json-file log driver, see https://docs.docker.com/config/containers/logging/journald/. Doing so means that the OS (RHEL8) will take care of our log files/rotation for us.

I've also updated the docs to show how to use this. You can get logs via docker or journalctl.

This is running on staging, where I've confirmed that it's working. In order to check both Redis and MyCustomDomain, I had to recreate the containers. Updating Redis to a new version is the easiest way, and also takes care of doing the update at the same time.

@humphd humphd added the category: deployment Related to building our local code into a working unit label Apr 4, 2023
@humphd humphd added this to the Milestone 0.9 milestone Apr 4, 2023
@humphd humphd requested review from Eakam1007 and a user April 4, 2023 20:29
@humphd humphd self-assigned this Apr 4, 2023
Copy link
Contributor

@Genne23v Genne23v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me!

@humphd humphd merged commit 4c01e9a into DevelopingSpace:main Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: deployment Related to building our local code into a working unit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Figure out logging and log rotation in production
3 participants