Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect Admin UI to landing page #529

Merged
merged 6 commits into from
Apr 6, 2023
Merged

Conversation

humphd
Copy link
Contributor

@humphd humphd commented Apr 5, 2023

We don't currently have a way for an admin to get to the Admin page. This adds another card to the landing page when a suer is an admin.

I've also cleaned up a few things in the landing page. However, the responsive widths aren't perfect, so maybe one of you could advise me on how to get it to wrap sooner.

Regular User

Screenshot 2023-04-05 at 2 30 26 PM

Admin User

Screenshot 2023-04-05 at 2 30 42 PM

@humphd humphd added the category: front end Front end part of our web service label Apr 5, 2023
@humphd humphd added this to the Milestone 0.9 milestone Apr 5, 2023
@humphd humphd self-assigned this Apr 5, 2023
@Eakam1007
Copy link
Contributor

Eakam1007 commented Apr 5, 2023

I believe this should make them more responsive. I tested this on my PC:
image

@humphd
Copy link
Contributor Author

humphd commented Apr 5, 2023

@Eakam1007 I'm stuck on how to do the selectors I need for these links to the instructions pages in testing now.

@humphd
Copy link
Contributor Author

humphd commented Apr 5, 2023

I've redone the landing page cards as actual cards, which seems to work better.

@Eakam1007
Copy link
Contributor

@Eakam1007 I'm stuck on how to do the selectors I need for these links to the instructions pages in testing now.

Since the links are no longer part of the paragraph now, I think this would be good solution getByRole('link', { name: 'these instructions' }).first() for the first link
and getByRole('link', { name: 'these instructions' }).nth(1) for the second.

@Eakam1007
Copy link
Contributor

We could extend these to the admin cards but we do not have a way to mock login as admin yet

@humphd
Copy link
Contributor Author

humphd commented Apr 5, 2023

@Eakam1007 I'm stuck on how to do the selectors I need for these links to the instructions pages in testing now.

Since the links are no longer part of the paragraph now, I think this would be good solution getByRole('link', { name: 'these instructions' }).first() for the first link and getByRole('link', { name: 'these instructions' }).nth(1) for the second.

Great, thank you. Fixed!

@humphd humphd requested a review from Eakam1007 April 5, 2023 23:11
Copy link
Contributor

@Eakam1007 Eakam1007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small question, rest looks great!

I have created #531 to allow tests to login in as admin. Could you please create an issue for adding tests for the admin card?

app/routes/__index/index.tsx Outdated Show resolved Hide resolved
@humphd humphd requested a review from Eakam1007 April 5, 2023 23:27
@humphd humphd merged commit ab7af78 into DevelopingSpace:main Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: front end Front end part of our web service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants