Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nginx cert config panel #536

Merged
merged 1 commit into from
Apr 7, 2023
Merged

Conversation

humphd
Copy link
Contributor

@humphd humphd commented Apr 6, 2023

Created another certificate config panel for nginx:

Screenshot 2023-04-06 at 3 07 34 PM

I'm going to need the work from #532 to create the full chain in the UI

@humphd humphd self-assigned this Apr 6, 2023
Copy link
Contributor

@Eakam1007 Eakam1007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, just realized that these links are not really obvious (that they are links)
image
On hover:
image
Would it be better to do the same thing as on the landing page for these:
image

@humphd
Copy link
Contributor Author

humphd commented Apr 6, 2023

Can we do some global fix for links so they have text decoration/red colour by default? It's stupid that we have to fix this in a lot of places.

@Eakam1007
Copy link
Contributor

Eakam1007 commented Apr 6, 2023

Can we do some global fix for links so they have text decoration/red colour by default? It's stupid that we have to fix this in a lot of places.

We probably can in another issue, cause we don't want the links in the header to be affected for example. Maybe a shared class. I could work on this later tonight if you like

Copy link
Contributor

@Eakam1007 Eakam1007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we can add the data after the other pr is merged

@Eakam1007 Eakam1007 mentioned this pull request Apr 6, 2023
Copy link
Contributor

@Genne23v Genne23v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@humphd humphd merged commit 1b6e132 into DevelopingSpace:main Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants