Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make links more obvious #544

Merged
merged 5 commits into from
Apr 7, 2023

Conversation

Eakam1007
Copy link
Contributor

Fixes #539

This changes all Chakra UI Link Components to have a base color of red (from our color theme), and a base text decoration of underline:

image

Since this only changes the base style, you can override the style as you normally would for any Charka UI component. Eg:

<Link color="black">

I have also updated the landing page links to use Charka UI's Link component, but as Remix's Link component. This preserves client-side routing but also keeps the Chakra UI styles (Relevant Chakra UI docs)

Steps to test

  • Run the app
  • Navigate to different links
  • Check that links preserve client-side routing when routing to our website
  • Check that link have the base style of red with an underline

@Eakam1007 Eakam1007 added this to the Milestone 0.9 milestone Apr 7, 2023
@Eakam1007 Eakam1007 self-assigned this Apr 7, 2023
@Eakam1007 Eakam1007 added category: front end Front end part of our web service area: web Web development related things [front end/back end] labels Apr 7, 2023
@Eakam1007 Eakam1007 requested review from humphd and Ririio April 7, 2023 15:41
@Eakam1007 Eakam1007 merged commit 65cf8d1 into DevelopingSpace:main Apr 7, 2023
@Eakam1007 Eakam1007 deleted the 539-make-links-obvious branch April 7, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: web Web development related things [front end/back end] category: front end Front end part of our web service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make links more obvious
3 participants