Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failures on CTL parsing #257

Open
thenextman opened this issue Mar 16, 2024 · 0 comments
Open

Test failures on CTL parsing #257

thenextman opened this issue Mar 16, 2024 · 0 comments

Comments

@thenextman
Copy link
Member

The following tests started failing:

x509::pkcs7::authenticode::test::full_validation_authenticode_signature_with_well_known_ca
x509::pkcs7::authenticode::test::full_validation_self_signed_authenticode_signature
x509::pkcs7::authenticode::test::full_validation_self_signed_authenticode_signature_with_only_leaf_certificate
x509::pkcs7::authenticode::test::full_validation_self_signed_authenticode_signature_with_root_and_leaf_certificate
x509::pkcs7::authenticode::test::self_signed_authenticode_signature_validation_against_ctl
x509::pkcs7::authenticode::test::self_signed_authenticode_signature_validation_against_ctl_with_excluded_ca_certificate
x509::pkcs7::authenticode::test::self_signed_authenticode_signature_validation_against_ctl_with_excluded_not_existing_ca_certificate
x509::pkcs7::ctl::tests::create_ctl

In all cases, the error is

panicked at 'called Result::unwrap() on an Err value: FailedToParseCtl(Cert(Asn1Deserialization { element: "pkcs7 certificate", source: InvalidData }))',

No commit in picky-rs can explain the regression; it's likely that something changed In Microsoft's serialized trust list. Although it's possible, I doubt the file is broken (it's used by Windows Update to update Windows' root certificates). Something in the current file is causing picky to choke.

As an interim measure, the tests were disabled in #256.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant