Infra cost reduction (Move from ECS to EC2) #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LDMGN
changed the title
|
infrastructure/lib/api-ec2-stack.ts
Outdated
| Instance, | ||
| InstanceClass, | ||
| InstanceSize, | ||
| InstanceType, Peer, Port, | ||
| InstanceType, KeyPair, |
There was a problem hiding this comment.
single import on one line ?
There was a problem hiding this comment.
Fixed, and removed one unused import.
| /* Database access. */ | ||
| const databaseSecurityGroup = SecurityGroup.fromSecurityGroupId(this, 'DatabaseSecurityGroup', props.database.securityGroup.id); | ||
| databaseSecurityGroup.connections.allowFrom(ec2SecurityGroup, Port.tcp(parseInt(props.database.port))); | ||
| // databaseSecurityGroup.connections.allowFrom(ec2SecurityGroup, Port.tcp(parseInt(props.database.port))); |
There was a problem hiding this comment.
do we need to keep this as comment ?
There was a problem hiding this comment.
Yes and no. It should be as limited as possible, but I don't have time to test it right now. So for now at least I'll add a TODO.
infrastructure/lib/database-stack.ts
Outdated
| import { | ||
| Credentials, | ||
| DatabaseInstance, | ||
| DatabaseInstanceEngine, | ||
| DatabaseInstanceEngine, DatabaseInstanceFromSnapshot, |
There was a problem hiding this comment.
one import on single line ?
Check line 9 as well
There was a problem hiding this comment.
Fixed by auto-formatting
MarcelWildenburg
approved these changes
Oct 18, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.