Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change thumbnail mounting dir to avoid nested mounts #1076

Open
Rivers47 opened this issue Sep 10, 2024 · 1 comment
Open

Change thumbnail mounting dir to avoid nested mounts #1076

Rivers47 opened this issue Sep 10, 2024 · 1 comment

Comments

@Rivers47
Copy link

Please describe your suggestion, and the problem it'd solve.
Currently the docker image mounts thumbnail to content/thumb which is very convoluted and LRRG will try to create a empty directory "thumb/ under content if user creates a thumbnail volume that mounts to content/thumb. Mounting a volume inside another bind mount should be avoided. I suggest either in tools/build/docker/Dockerfile remove

VOLUME [ "/home/koyomi/lanraragi/content/thumb" ]

alltogether and let user decide where thumbnails should be,
or change it to

VOLUME [ "/home/koyomi/lanraragi/thumb" ]

Additional context
none

@Difegue
Copy link
Owner

Difegue commented Oct 12, 2024

hmm, the idea with that mount was to keep the previous behavior where thumbnails were always in the content folder by default, but maybe I should just give up on that and have it in a fully separated folder for good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants