Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 4 Functional Tests #192

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Fix 4 Functional Tests #192

merged 2 commits into from
Mar 11, 2024

Conversation

ghost
Copy link

@ghost ghost commented Mar 10, 2024 •
edited by ghost
Loading

This PR fixes 4 functional tests.

To test this:

Compile:

./autogen.sh
./configure
make -j 8

Run Specific Functional Tests

python rpc_createmultisig.py --descriptors 
python rpc_createmultisig.py --legacy-wallet

Update

wallet_coinbase_category.py --descriptors
wallet_coinbase_category.py --legacy-wallet

JaredTate
JaredTate previously approved these changes Mar 11, 2024
View reviewed changes
Copy link

@JaredTate JaredTate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Compiles & runs good.
Screenshot 2024-03-11 at 10 02 40 AM

ycagel
ycagel previously approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@ycagel ycagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cACK. Thanks @Jongjan88!

@ghost ghost dismissed stale reviews from ycagel and JaredTate via f79ce55 March 11, 2024 22:54
@ghost ghost changed the title Fix 2 Functional Tests Fix 4 Functional Tests Mar 11, 2024
@ghost ghost requested review from JaredTate and ycagel March 11, 2024 22:55
gto90
gto90 approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@gto90 gto90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

JaredTate
JaredTate approved these changes Mar 11, 2024
View reviewed changes
Copy link

@JaredTate JaredTate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Compiles and runs good!
Screenshot 2024-03-11 at 5 42 08 PM

ycagel
ycagel approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@ycagel ycagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cACK. Thanks @Jongjan88!

@ycagel ycagel merged commit 3fd7c74 into DigiByte-Core:develop Mar 11, 2024
@ghost ghost deleted the minipr2 branch March 12, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SmartArray SmartArray Awaiting requested review from SmartArray

@digicontributer digicontributer Awaiting requested review from digicontributer

@j50ng j50ng Awaiting requested review from j50ng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JaredTate @ycagel @gto90