Make descriptor wallets by default

[ghost]

Like they did in bitcoin 23. Change the default wallet type from legacy ( Berkeley DB ) to descriptor ( SQLite ).

---

Why move from Berkeley DB?

Not designed to be used as an application data file. The Legacy Wallet has several hacks to get round this as a result and Berkeley DB wallet files can easily be corrupted.
Berkeley DB produces extra files which need to be moved with the database file. This means that Berkeley DB is less portable and requires a directory for each wallet.
Changes were introduced to Berkeley DB database environment files breaking backwards compatibility.

Why choose SQLite?

Can be used as an application data file.

New SQLite versions maintains backwards compatibility with versions as far back as 2013.

Does not require database environment. A completed write guarantees that the data was written to the database file.

Can now move to single wallet files instead of wallet directories.

---

---

Screencast.from.2024-03-22.00-58-48.webm

Issue #199

[JaredTate]

Looks good. Wallet compiles, runs & make check tests passes. When I go to create wallet descriptor was default. Was able to create one no issues.

[ycagel]

cACK

[JaredTate]

It does appear this causes 1 functional test that was passing to fail now:

tool_wallet.py --legacy-wallet

[ghost]

It does appear this causes 1 functional test that was passing to fail now:

tool_wallet.py --legacy-wallet

Should work now tnx!

[JaredTate]

ACK! Great stuff! Test passing now for me and wallet works great.

[ycagel]

cACK

[saltedlolly]

I have tested this on Apple Silicon and it is working fine. It is worth noting that with the descriptor wallet I am no longer experiencing the freezing at startup that you get with the legacy wallet.

descriptor.wallet.mov

[saltedlolly]

That said if I try to open a legacy wallet when already running the descriptor wallet it is freezing permanently - it got stuck beachballing on the video below. I suspect this is a seperate issue but worth mentioning.

Screen.Recording.2024-03-23.at.4.13.53.pm.mov

[gto90]

utACK