Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix:edition rapide de la date de livraison et propagation vers la commande #31437

Open
wants to merge 1 commit into
base: 19.0
Choose a base branch
from

Conversation

ATM-NicolasV
Copy link
Contributor

FIX|Fix #[issue_number Short description]

Pouvoir modifier la date de livraison via le alwayseditable au statut brouillon et propagation de la valeur lors de la création d'une commande

…ion de la valeur lors de la création d'une commande
@@ -1692,7 +1692,8 @@
print '<table class="nobordernopadding" width="100%"><tr><td>';
print $langs->trans('DeliveryDate');
print '</td>';
if ($action != 'editdate_livraison' && $object->statut == SupplierProposal::STATUS_VALIDATED) {
// Pourquoi avoir une régle diffrente des autres champs pour l'edition de la date ?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no reason for this test. Test on not signed as suggested seems better.

Can you remive the comment so i can validate pr. Question on code should be added in github comment, not into code itself.

@eldy eldy added the PR to fix or conflict to solve PR needs to be fixed to be integrated (except for conflicts, a comment describes the fix to do) label Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR to fix or conflict to solve PR needs to be fixed to be integrated (except for conflicts, a comment describes the fix to do)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants