feat: add 'Keys' variable to enum values and check for hotKeys #2463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 68320fe:
|
added 7 commits
September 2, 2024 14:57
DaiQiangReal
reviewed
Sep 9, 2024
DaiQiangReal
reviewed
Sep 9, 2024
content/input/hotkeys/index-en-US.md
Outdated
| @@ -180,14 +230,14 @@ function Demo() { | |||
|
|
|||
| | Property | Instructions | type | Default | | |||
| |-------------------|-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|---------------------------------|-----------| | |||
| | hotKeys | Define keyboard shortcut，[values](https://developer.mozilla.org/en-US/docs/Web/API/UI_Events/Keyboard_event_key_values) | KeyboardEvent.key[] | - | | |||
| | blockDefault | Whether to prevent the default behavior of the shortcut | boolean | false | | |||
There was a problem hiding this comment.
改成和原生一样的 preventDefault 吧
DaiQiangReal
reviewed
Sep 9, 2024
content/input/hotkeys/index-en-US.md
Outdated
| ```jsx live=true | ||
| import React, { useState } from 'react'; | ||
| import { HotKeys, Tag } from '@douyinfe/semi-ui'; | ||
| import { HotKeys, Keys, Modal, Tag } from '@douyinfe/semi-ui'; |
There was a problem hiding this comment.
把枚举的 Keys 放到 HotKeys 的static 属性上吧，不要让用户单独 import 了，有点分散
DaiQiangReal
reviewed
Sep 9, 2024
packages/semi-ui/hotKeys/index.tsx
Outdated
| this.props.onClick(); | ||
| notifyHotKey: () => { | ||
| if (this.props.onHotKey && typeof this.props.onHotKey === 'function') { | ||
| this.props.onHotKey(); |
There was a problem hiding this comment.
this.props.onHotKey?.() 然后不要忘记把事件 event 也作为入参
packages/semi-ui/hotKeys/index.tsx
Outdated
| if (this.props.getListenerTarget) { | ||
| return this.props.getListenerTarget(); | ||
| if (this.props.getListenerTarget && typeof this.props.getListenerTarget === 'function') { | ||
| return this.props.getListenerTarget?.(); |
| } | ||
| }); | ||
|
|
||
| return commonKeyCnt === 1; |
There was a problem hiding this comment.
commonKeyCnt 大于一现在是不支持？如果检测到大于一的话，也给个报错吧
semi-design
|
||||||||||||||||||||||||||||||
| Project |
semi-design
|
| Branch Review |
release
|
| Run status |
|
| Run duration | 10m 11s |
| Commit |
|
| Committer | 代强 |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
11
|
Flaky
|
0
|
Pending
|
11
|
Skipped
|
0
|
Passing
|
253
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
Tests for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
中文模板 / Chinese Template
What kind of change does this PR introduce? (check at least one)
PR description
Fixes #
Changelog
🇨🇳 Chinese
Keys变量，并为用户定义快捷键添加有效性检查🇺🇸 English
Checklist
Other
Additional information